Skip to content

Commit

Permalink
url: remove U+0000 case in the fragment state
Browse files Browse the repository at this point in the history
Port of whatwg/url#486

PR-URL: #33770
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
targos authored and nodejs-github-bot committed Sep 16, 2020
1 parent eb9d7a4 commit 4831278
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions src/node_url.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2084,8 +2084,6 @@ void URL::Parse(const char* input,
url->flags |= URL_FLAGS_HAS_FRAGMENT;
url->fragment = std::move(buffer);
break;
case 0:
break;
default:
AppendOrEscape(&buffer, ch, FRAGMENT_ENCODE_SET);
}
Expand Down
3 changes: 0 additions & 3 deletions test/wpt/status/url.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
"idlharness.any.js": {
"fail": "getter/setter names are wrong, etc."
},
"url-setters-stripping.any.js": {
"fail": "TODO: port https://github.com/whatwg/url/pull/486"
},
"urlsearchparams-constructor.any.js": {
"fail": "TODO: fix https://github.com/nodejs/node/issues/33892"
},
Expand Down

0 comments on commit 4831278

Please sign in to comment.