lib: fix coverage reporting

Taking the source code of a function and running it in another context does not play well with coverage instrumentation. For now, do the simple thing and just write the source code as a string literal. Fixes: #19912 Refs: #19524 PR-URL: #20035 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Apr 16, 2018 · 445a89f · 445a89f
1 parent 4b73383
commit 445a89f
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -390,17 +390,16 @@ function isInsideNodeModules() {
     // Use `runInNewContext()` to get something tamper-proof and
     // side-effect-free. Since this is currently only used for a deprecated API,
     // the perf implications should be okay.
-    getStructuredStack = runInNewContext('(' + function() {
+    getStructuredStack = runInNewContext(`(function() {
       Error.prepareStackTrace = function(err, trace) {
         err.stack = trace;
       };
       Error.stackTraceLimit = Infinity;
 
       return function structuredStack() {
-        // eslint-disable-next-line no-restricted-syntax
         return new Error().stack;
       };
-    } + ')()', {}, { filename: 'structured-stack' });
+    })()`, {}, { filename: 'structured-stack' });
   }
 
   const stack = getStructuredStack();