events: make eventTarget.removeAllListeners() return this

Fixes: #35762 PR-URL: #35805 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Nov 3, 2020 · 438d9de · 438d9de
1 parent 8074f69
commit 438d9de
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/doc/api/events.md b/doc/api/events.md
@@ -1525,6 +1525,8 @@ added: v14.5.0
 
 * `type` {string}
 
+* Returns: {EventTarget} this
+
 Node.js-specific extension to the `EventTarget` class. If `type` is specified,
 removes all registered listeners for `type`, otherwise removes all registered
 listeners.

diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -476,6 +476,8 @@ class NodeEventTarget extends EventTarget {
     } else {
       this[kEvents].clear();
     }
+
+    return this;
   }
 }
 

diff --git a/test/parallel/test-nodeeventtarget.js b/test/parallel/test-nodeeventtarget.js
@@ -117,11 +117,11 @@ const { on } = require('events');
   strictEqual(eventTarget.listenerCount('foo'), 2);
   strictEqual(eventTarget.listenerCount('bar'), 1);
   deepStrictEqual(eventTarget.eventNames(), ['foo', 'bar']);
-  eventTarget.removeAllListeners('foo');
+  strictEqual(eventTarget.removeAllListeners('foo'), eventTarget);
   strictEqual(eventTarget.listenerCount('foo'), 0);
   strictEqual(eventTarget.listenerCount('bar'), 1);
   deepStrictEqual(eventTarget.eventNames(), ['bar']);
-  eventTarget.removeAllListeners();
+  strictEqual(eventTarget.removeAllListeners(), eventTarget);
   strictEqual(eventTarget.listenerCount('foo'), 0);
   strictEqual(eventTarget.listenerCount('bar'), 0);
   deepStrictEqual(eventTarget.eventNames(), []);
-Original file line number
+Diff line change
@@ Expand Up / @@ -476,6 +476,8 @@ class NodeEventTarget extends EventTarget { @@
         } else {
           this[kEvents].clear();
         }
+        return this;
       }
     }
@@ Expand Down @@