Skip to content

Commit

Permalink
src: move C++ binding/addon related code into node_binding{.h, .cc}
Browse files Browse the repository at this point in the history
This patch:

- Moves the C++ binding/addon related code out of
  node_internals.h/node.cc and into dedicated files
  node_binding.h/node_binding.cc, and only puts the code resued
  by other files into the header.
- Introduce a node::binding namespace so that code exposed to
  other files can be easily recognized.

PR-URL: #24701
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
joyeecheung authored and Trott committed Dec 1, 2018
1 parent 976065d commit 3d66826
Show file tree
Hide file tree
Showing 6 changed files with 552 additions and 509 deletions.
2 changes: 2 additions & 0 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@
'src/module_wrap.cc',
'src/node.cc',
'src/node_api.cc',
'src/node_binding.cc',
'src/node_buffer.cc',
'src/node_config.cc',
'src/node_constants.cc',
Expand Down Expand Up @@ -414,6 +415,7 @@
'src/node.h',
'src/node_api.h',
'src/node_api_types.h',
'src/node_binding.h',
'src/node_buffer.h',
'src/node_constants.h',
'src/node_context_data.h',
Expand Down
Loading

0 comments on commit 3d66826

Please sign in to comment.