process: use defineProperty instead of assignment

PR-URL: #43907 Fixes: #43496 Refs: endojs/endo#576 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mestery <[email protected]>
nodejs · Jul 31, 2022 · 3afa881 · 3afa881
1 parent 5a0057d
commit 3afa881
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js
@@ -15,6 +15,7 @@ const {
   Float64Array,
   NumberMAX_SAFE_INTEGER,
   ObjectFreeze,
+  ObjectDefineProperty,
   ReflectApply,
   RegExpPrototypeTest,
   SafeArrayIterator,
@@ -371,9 +372,15 @@ function buildAllowedFlags() {
       return SetPrototypeValues(this[kInternal].set);
     }
   }
-  NodeEnvironmentFlagsSet.prototype.keys =
-  NodeEnvironmentFlagsSet.prototype[SymbolIterator] =
-    NodeEnvironmentFlagsSet.prototype.values;
+  const flagSetValues = NodeEnvironmentFlagsSet.prototype.values;
+  ObjectDefineProperty(NodeEnvironmentFlagsSet.prototype, SymbolIterator, {
+    __proto__: null,
+    value: flagSetValues,
+  });
+  ObjectDefineProperty(NodeEnvironmentFlagsSet.prototype, 'keys', {
+    __proto__: null,
+    value: flagSetValues,
+  });
 
   ObjectFreeze(NodeEnvironmentFlagsSet.prototype.constructor);
   ObjectFreeze(NodeEnvironmentFlagsSet.prototype);