process: fix omitting -- from process.execArgv

This was essentially a typo that went unnoticed because we didn’t have tests for this particular situation. Fixes: #24647 PR-URL: #24654 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
nodejs · Feb 20, 2019 · 38b0e5d · 38b0e5d
1 parent dbc01e1
commit 38b0e5d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/src/node_options-inl.h b/src/node_options-inl.h
@@ -266,7 +266,7 @@ struct ArgsInfo {
       // on the command line (i.e. not generated through alias expansion).
       // '--' is a special case here since its purpose is to end `exec_argv`,
       // which is why we do not include it.
-      if (exec_args != nullptr && first() != "--")
+      if (exec_args != nullptr && ret != "--")
         exec_args->push_back(ret);
       underlying->erase(underlying->begin() + 1);
     } else {

diff --git a/test/parallel/test-process-exec-argv.js b/test/parallel/test-process-exec-argv.js
@@ -27,16 +27,19 @@ const spawn = require('child_process').spawn;
 if (process.argv[2] === 'child') {
   process.stdout.write(JSON.stringify(process.execArgv));
 } else {
-  const execArgv = ['--stack-size=256'];
-  const args = [__filename, 'child', 'arg0'];
-  const child = spawn(process.execPath, execArgv.concat(args));
-  let out = '';
+  for (const extra of [ [], [ '--' ] ]) {
+    const execArgv = ['--stack-size=256'];
+    const args = [__filename, 'child', 'arg0'];
+    const child = spawn(process.execPath, [...execArgv, ...extra, ...args]);
+    let out = '';
 
-  child.stdout.on('data', function(chunk) {
-    out += chunk;
-  });
+    child.stdout.setEncoding('utf8');
+    child.stdout.on('data', function(chunk) {
+      out += chunk;
+    });
 
-  child.on('close', function() {
-    assert.deepStrictEqual(JSON.parse(out), execArgv);
-  });
+    child.on('close', function() {
+      assert.deepStrictEqual(JSON.parse(out), execArgv);
+    });
+  }
 }