test: scope redeclared variable

`test-assert.js` redeclares a variable with `var`. This change converts it to a `const` declaration and wraps it in a standalone block to scope it to just the test that uses it. PR-URL: #4854 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
nodejs · Jan 26, 2016 · 34daaa7 · 34daaa7
1 parent 6a73dba
commit 34daaa7
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -73,9 +73,11 @@ assert.throws(makeBlock(a.deepEqual, /a/i, /a/));
 assert.throws(makeBlock(a.deepEqual, /a/m, /a/));
 assert.throws(makeBlock(a.deepEqual, /a/igm, /a/im));
 
-var re1 = /a/;
-re1.lastIndex = 3;
-assert.throws(makeBlock(a.deepEqual, re1, /a/));
+{
+  const re1 = /a/;
+  re1.lastIndex = 3;
+  assert.throws(makeBlock(a.deepEqual, re1, /a/));
+}
 
 
 // 7.4
@@ -172,10 +174,11 @@ assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/));
 assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/));
 assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im));
 
-var re1 = /a/;
-re1.lastIndex = 3;
-assert.throws(makeBlock(a.deepStrictEqual, re1, /a/));
-
+{
+  const re1 = /a/;
+  re1.lastIndex = 3;
+  assert.throws(makeBlock(a.deepStrictEqual, re1, /a/));
+}
 
 // 7.4 - strict
 assert.throws(makeBlock(a.deepStrictEqual, 4, '4'),