bootstrap: call _undestroy() inside _destroy for stdout and stderr

This change makes `process.stdout` and `process.stderr` to be automatically undestroyed when ended/destrouyed, therefore making it always possible to write/console.log to stdout. Fixes: #39447 PR-URL: #39685 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Aug 11, 2021 · 33f9b7f · 33f9b7f
1 parent 3914354
commit 33f9b7f
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/lib/internal/bootstrap/switches/is_main_thread.js b/lib/internal/bootstrap/switches/is_main_thread.js
@@ -100,6 +100,7 @@ function createWritableStdioStream(fd) {
 
 function dummyDestroy(err, cb) {
   cb(err);
+  this._undestroy();
 
   // We need to emit 'close' anyway so that the closing
   // of the stream is observable. We just make sure we

diff --git a/test/parallel/test-stdio-undestroy.js b/test/parallel/test-stdio-undestroy.js
@@ -0,0 +1,36 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const spawn = require('child_process').spawn;
+
+if (process.argv[2] === 'child') {
+  process.stdout.destroy();
+  process.stderr.destroy();
+  console.log('stdout');
+  process.stdout.write('rocks\n');
+  console.error('stderr');
+  setTimeout(function() {
+    process.stderr.write('rocks too\n');
+  }, 10);
+  return;
+}
+
+const proc = spawn(process.execPath, [__filename, 'child'], { stdio: 'pipe' });
+
+let stdout = '';
+proc.stdout.setEncoding('utf8');
+proc.stdout.on('data', common.mustCallAtLeast(function(chunk) {
+  stdout += chunk;
+}, 1));
+
+let stderr = '';
+proc.stderr.setEncoding('utf8');
+proc.stderr.on('data', common.mustCallAtLeast(function(chunk) {
+  stderr += chunk;
+}, 1));
+
+proc.on('exit', common.mustCall(function(exitCode) {
+  assert.strictEqual(exitCode, 0);
+  assert.strictEqual(stdout, 'stdout\nrocks\n');
+  assert.strictEqual(stderr, 'stderr\nrocks too\n');
+}));