Skip to content

Commit

Permalink
build: run linter before running tests
Browse files Browse the repository at this point in the history
PR-URL: #16284
Fixes: https://github.com/node/issues/16283
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
joyeecheung committed Oct 29, 2017
1 parent a70ef36 commit 2875459
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,26 @@ test: all
$(MAKE) build-addons
$(MAKE) build-addons-napi
$(MAKE) doc-only
$(MAKE) lint
$(MAKE) cctest
$(PYTHON) tools/test.py --mode=release -J \
$(CI_ASYNC_HOOKS) \
$(CI_JS_SUITES) \
$(CI_NATIVE_SUITES) \
doctool known_issues
$(MAKE) lint
endif

# For a quick test, does not run linter or build doc
test-only: all
$(MAKE) build-addons
$(MAKE) build-addons-napi
$(MAKE) cctest
$(PYTHON) tools/test.py --mode=release -J \
$(CI_ASYNC_HOOKS) \
$(CI_JS_SUITES) \
$(CI_NATIVE_SUITES) \
known_issues

test-cov: all
$(MAKE) build-addons
$(MAKE) build-addons-napi
Expand Down Expand Up @@ -1107,6 +1118,7 @@ endif
test-gc \
test-gc-clean \
test-hash-seed \
test-only \
test-v8 \
test-v8-all \
test-v8-benchmarks \
Expand Down

0 comments on commit 2875459

Please sign in to comment.