url: fix inconsistent port in url.resolveObject

This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: #8213 PR-URL: #8214 Reviewed-By: James M Snell <[email protected]>
nodejs · Aug 23, 2016 · 286d44e · 286d44e
1 parent b4ea3a0
commit 286d44e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/url.js b/lib/url.js
@@ -781,6 +781,7 @@ Url.prototype.resolveObject = function(relative) {
     // it's absolute.
     if (relative.host || relative.host === '') {
       result.host = relative.host;
+      result.port = relative.port;
       result.auth = null;
     }
     if (relative.hostname || relative.hostname === '') {

diff --git a/test/parallel/test-url.js b/test/parallel/test-url.js
@@ -1570,6 +1570,11 @@ var relativeTests2 = [
    'http://asdf:[email protected]',
    'http://diff:[email protected]/'],
 
+  // changing port
+  ['https://example.com:81/',
+   'https://example.com:82/',
+   'https://example.com:81/'],
+
   // https://github.com/nodejs/node/issues/1435
   ['https://another.host.com/',
    'https://user:[email protected]/',