Skip to content

Commit

Permalink
domain: add name to monkey-patched emit function
Browse files Browse the repository at this point in the history
The domain module monkey patches EventEmitter.prototype.emit(),
however the function's name was becoming the empty string. This
commit forces the new emit function to have the proper name.

PR-URL: #37550
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
cjihrig authored and danielleadams committed Mar 16, 2021
1 parent 1c09776 commit 236ba04
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/domain.js
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ EventEmitter.init = function() {
};

const eventEmit = EventEmitter.prototype.emit;
EventEmitter.prototype.emit = function(...args) {
EventEmitter.prototype.emit = function emit(...args) {
const domain = this.domain;

const type = args[0];
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-domain-dep0097.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const inspector = require('inspector');

process.on('warning', common.mustCall((warning) => {
assert.strictEqual(warning.code, 'DEP0097');
assert.match(warning.message, /Triggered by calling <anonymous> on process/);
assert.match(warning.message, /Triggered by calling emit on process/);
}));

domain.create().run(() => {
Expand Down

0 comments on commit 236ba04

Please sign in to comment.