Skip to content

Commit

Permalink
doc: improve ninja build for --built-in-modules-path
Browse files Browse the repository at this point in the history
The current ninja build does not work with `--node-builtin-modules-path`
flag without passing `--ninja` as it will use `make` to build from
scratch again.

PR-URL: #53007
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
  • Loading branch information
jakecastelli authored and marco-ippolito committed Jul 19, 2024
1 parent ba764db commit 1dc406b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions doc/contributing/building-node-with-ninja.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ doing so can be significantly quicker than using `make`. Please see
[Ninja][] is supported in the Makefile. Run `./configure --ninja` to configure
the project to run the regular `make` commands with Ninja.

When modifying only the JS layer in `lib`, you can use:

```bash
./configure --ninja --node-builtin-modules-path "$(pwd)"
```

For example, `make` will execute `ninja -C out/Release` internally
to produce a compiled release binary, It will also execute
`ln -fs out/Release/node node`, so that you can execute `./node` at
Expand Down

0 comments on commit 1dc406b

Please sign in to comment.