Skip to content

Commit

Permalink
test: try other ipv6 localhost alternatives
Browse files Browse the repository at this point in the history
PR-URL: #4325
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
mscdex authored and Myles Borins committed Jan 19, 2016
1 parent 1ebb0c0 commit 1bc44e7
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 41 deletions.
13 changes: 13 additions & 0 deletions test/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,19 @@ var opensslCli = null;
var inFreeBSDJail = null;
var localhostIPv4 = null;

exports.localIPv6Hosts = [
// Debian/Ubuntu
'ip6-localhost',
'ip6-loopback',

// SUSE
'ipv6-localhost',
'ipv6-loopback',

// Typically universal
'localhost',
];

Object.defineProperty(exports, 'inFreeBSDJail', {
get: function() {
if (inFreeBSDJail !== null) return inFreeBSDJail;
Expand Down
96 changes: 55 additions & 41 deletions test/parallel/test-net-connect-options-ipv6.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var net = require('net');
var dns = require('dns');
const common = require('../common');
const assert = require('assert');
const net = require('net');
const dns = require('dns');

if (!common.hasIPv6) {
console.log('1..0 # Skipped: no IPv6 support');
Expand All @@ -12,46 +12,60 @@ if (!common.hasIPv6) {
var serverGotEnd = false;
var clientGotEnd = false;

dns.lookup('localhost', 6, function(err) {
if (err) {
console.error('Looks like IPv6 is not really supported');
console.error(err);
return;
}
const hosts = common.localIPv6Hosts;
var hostIdx = 0;
var host = hosts[hostIdx];
var localhostTries = 10;

var server = net.createServer({allowHalfOpen: true}, function(socket) {
socket.resume();
socket.on('end', function() {
serverGotEnd = true;
});
socket.end();
const server = net.createServer({allowHalfOpen: true}, function(socket) {
socket.resume();
socket.on('end', function() {
serverGotEnd = true;
});
socket.end();
});

server.listen(common.PORT, '::1', function() {
var client = net.connect({
host: 'localhost',
port: common.PORT,
family: 6,
allowHalfOpen: true
}, function() {
console.error('client connect cb');
client.resume();
client.on('end', function() {
clientGotEnd = true;
setTimeout(function() {
assert(client.writable);
client.end();
}, 10);
});
client.on('close', function() {
server.close();
});
server.listen(common.PORT, '::1', tryConnect);

function tryConnect() {
const client = net.connect({
host: host,
port: common.PORT,
family: 6,
allowHalfOpen: true
}, function() {
console.error('client connect cb');
client.resume();
client.on('end', function() {
clientGotEnd = true;
setTimeout(function() {
assert(client.writable);
client.end();
}, 10);
});
client.on('close', function() {
server.close();
});
}).on('error', function(err) {
if (err.syscall === 'getaddrinfo' && err.code === 'ENOTFOUND') {
if (host !== 'localhost' || --localhostTries === 0)
host = hosts[++hostIdx];
if (host)
tryConnect();
else {
console.log('1..0 # Skipped: no IPv6 localhost support');
process.removeListener('exit', onExit);
server.close();
}
return;
}
throw err;
});
}

process.on('exit', function() {
console.error('exit', serverGotEnd, clientGotEnd);
assert(serverGotEnd);
assert(clientGotEnd);
});
});
process.on('exit', onExit);
function onExit() {
console.error('exit', serverGotEnd, clientGotEnd);
assert(serverGotEnd);
assert(clientGotEnd);
}

0 comments on commit 1bc44e7

Please sign in to comment.