src: indent long help text properly

The previous code passed an ignored argument to StringPrototypeTrimLeft, and tried to trim a string that didn't start with whitespace. The trim makes more sense after the indentation has been added. Now wrapped lines actually show up with the rest of the help text. Doing this made an uncharacteristic trailing newline in the `--icu-data-dir` help text more obvious, so I removed that. PR-URL: #37911 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 28, 2021 · 19ed27d · 19ed27d
1 parent ce6d756
commit 19ed27d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/internal/main/print_help.js b/lib/internal/main/print_help.js
@@ -152,8 +152,8 @@ function format(
     else
       text += StringPrototypeRepeat(' ', firstColumn - displayName.length);
 
-    text += indent(StringPrototypeTrimLeft(fold(displayHelpText, secondColumn),
-                                           firstColumn)) + '\n';
+    text += StringPrototypeTrimLeft(
+      indent(fold(displayHelpText, secondColumn), firstColumn)) + '\n';
   }
 
   if (maxFirstColumnUsed < firstColumn - 4) {

diff --git a/src/node_options.cc b/src/node_options.cc
@@ -729,7 +729,7 @@ PerProcessOptionsParser::PerProcessOptionsParser(
   AddOption("--icu-data-dir",
             "set ICU data load path to dir (overrides NODE_ICU_DATA)"
 #ifndef NODE_HAVE_SMALL_ICU
-            " (note: linked-in ICU data is present)\n"
+            " (note: linked-in ICU data is present)"
 #endif
             ,
             &PerProcessOptions::icu_data_dir,