buffer: faster case for create buffer from empty string

When create Buffer from empty string will touch C++ binding also. This patch can improve edge case ~70% faster. PR-URL: #4414 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 30, 2016 · 18db2af · 18db2af
1 parent ee83c95
commit 18db2af
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/benchmark/buffers/buffer_zero.js b/benchmark/buffers/buffer_zero.js
@@ -3,16 +3,21 @@
 const common = require('../common.js');
 
 const bench = common.createBenchmark(main, {
-  n: [1024]
+  n: [1024],
+  type: ['buffer', 'string']
 });
 
-const zero = new Buffer(0);
+const zeroBuffer = Buffer.alloc(0);
+const zeroString = '';
 
 function main(conf) {
   var n = +conf.n;
   bench.start();
-  for (let i = 0; i < n * 1024; i++) {
-    new Buffer(zero);
-  }
+
+  if (conf.type === 'buffer')
+    for (let i = 0; i < n * 1024; i++) Buffer.from(zeroBuffer);
+  else if (conf.type === 'string')
+    for (let i = 0; i < n * 1024; i++) Buffer.from(zeroString);
+
   bench.end(n);
 }
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -192,6 +192,10 @@ function fromString(string, encoding) {
     encoding = 'utf8';
 
   var length = byteLength(string, encoding);
+
+  if (length === 0)
+    return Buffer.alloc(0);
+
   if (length >= (Buffer.poolSize >>> 1))
     return binding.createFromString(string, encoding);