lib: use emitWarning instead of printDeprecationMessage

The process.emitWarning() API should be used for printing deprecation warning messages rather than directly using the internal/util#printDeprecationMessage PR-URL: #8166 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Myles Borins <[email protected]>
nodejs · Sep 2, 2016 · 15eaba9 · 15eaba9
1 parent bf91035
commit 15eaba9
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 11 deletions.
diff --git a/lib/_linklist.js b/lib/_linklist.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const msg = require('internal/util').printDeprecationMessage;
-
 module.exports = require('internal/linkedlist');
-msg('_linklist module is deprecated. Please use a userland alternative.');
+process.emitWarning(
+  '_linklist module is deprecated. Please use a userland alternative.',
+  'DeprecationWarning');
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -63,7 +63,10 @@ exports._deprecate = function(fn, msg) {
 
   var warned = false;
   function deprecated() {
-    warned = exports.printDeprecationMessage(msg, warned, deprecated);
+    if (!warned) {
+      warned = true;
+      process.emitWarning(msg, 'DeprecationWarning', deprecated);
+    }
     if (new.target) {
       return Reflect.construct(fn, arguments, new.target);
     }

diff --git a/lib/module.js b/lib/module.js
@@ -196,10 +196,14 @@ Module._findPath = function(request, paths, isMain) {
     if (filename) {
       // Warn once if '.' resolved outside the module dir
       if (request === '.' && i > 0) {
-        warned = internalUtil.printDeprecationMessage(
-          'warning: require(\'.\') resolved outside the package ' +
-          'directory. This functionality is deprecated and will be removed ' +
-          'soon.', warned);
+        if (!warned) {
+          warned = true;
+          process.emitWarning(
+            'warning: require(\'.\') resolved outside the package ' +
+            'directory. This functionality is deprecated and will be removed ' +
+            'soon.',
+            'DeprecationWarning');
+        }
       }
 
       Module._pathCache[cacheKey] = filename;

diff --git a/lib/sys.js b/lib/sys.js
@@ -1,10 +1,9 @@
 'use strict';
 
-const util = require('internal/util');
-
 // the sys module was renamed to 'util'.
 // this shim remains to keep old programs working.
 // sys is deprecated and shouldn't be used
 
 module.exports = require('util');
-util.printDeprecationMessage('sys is deprecated. Use util instead.');
+process.emitWarning('sys is deprecated. Use util instead.',
+                    'DeprecationWarning');