Skip to content

Commit

Permalink
deps: backport 2cd2f5feff3 from upstream v8
Browse files Browse the repository at this point in the history
Original commit message:

    Remove experimental fast accessor builder API

    As the code isn't used, but would have to be ported from hand-written
    assembly to CodeStubAssembler anyways, I propose to remove it and
    restore it if we decide that we actually need it.

    [email protected]
    BUG=

    Change-Id: Iffd7fc6ec534b1dd7a9144da900424355c8a7a02
    Reviewed-on: https://chromium-review.googlesource.com/453461
    Commit-Queue: Jochen Eisinger <[email protected]>
    Reviewed-by: Daniel Vogelheim <[email protected]>
    Reviewed-by: Benedikt Meurer <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#43763}

Ref: v8/v8@2cd2f5feff3

PR-URL: #12875
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
jeisinger authored and jasnell committed May 23, 2017
1 parent 036c66c commit 0ce23da
Show file tree
Hide file tree
Showing 37 changed files with 14 additions and 2,336 deletions.
5 changes: 0 additions & 5 deletions deps/v8/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,6 @@ v8_source_set("v8_base") {

### gcmole(all) ###
"include/v8-debug.h",
"include/v8-experimental.h",
"include/v8-platform.h",
"include/v8-profiler.h",
"include/v8-testing.h",
Expand All @@ -905,8 +904,6 @@ v8_source_set("v8_base") {
"src/api-arguments-inl.h",
"src/api-arguments.cc",
"src/api-arguments.h",
"src/api-experimental.cc",
"src/api-experimental.h",
"src/api-natives.cc",
"src/api-natives.h",
"src/api.cc",
Expand Down Expand Up @@ -1386,8 +1383,6 @@ v8_source_set("v8_base") {
"src/external-reference-table.h",
"src/factory.cc",
"src/factory.h",
"src/fast-accessor-assembler.cc",
"src/fast-accessor-assembler.h",
"src/fast-dtoa.cc",
"src/fast-dtoa.h",
"src/feedback-vector-inl.h",
Expand Down
58 changes: 0 additions & 58 deletions deps/v8/include/v8-experimental.h

This file was deleted.

19 changes: 2 additions & 17 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ class CallHandlerHelper;
class EscapableHandleScope;
template<typename T> class ReturnValue;

namespace experimental {
class FastAccessorBuilder;
} // namespace experimental

namespace internal {
class Arguments;
class Heap;
Expand Down Expand Up @@ -5098,16 +5094,6 @@ class V8_EXPORT FunctionTemplate : public Template {
static MaybeLocal<FunctionTemplate> FromSnapshot(Isolate* isolate,
size_t index);

/**
* Creates a function template with a fast handler. If a fast handler is set,
* the callback cannot be null.
*/
static Local<FunctionTemplate> NewWithFastHandler(
Isolate* isolate, FunctionCallback callback,
experimental::FastAccessorBuilder* fast_handler = nullptr,
Local<Value> data = Local<Value>(),
Local<Signature> signature = Local<Signature>(), int length = 0);

/**
* Creates a function template backed/cached by a private property.
*/
Expand Down Expand Up @@ -5135,9 +5121,8 @@ class V8_EXPORT FunctionTemplate : public Template {
* callback is called whenever the function created from this
* FunctionTemplate is called.
*/
void SetCallHandler(
FunctionCallback callback, Local<Value> data = Local<Value>(),
experimental::FastAccessorBuilder* fast_handler = nullptr);
void SetCallHandler(FunctionCallback callback,
Local<Value> data = Local<Value>());

/** Set the predefined length property for the FunctionTemplate. */
void SetLength(int length);
Expand Down
139 changes: 0 additions & 139 deletions deps/v8/src/api-experimental.cc

This file was deleted.

28 changes: 0 additions & 28 deletions deps/v8/src/api-experimental.h

This file was deleted.

Loading

0 comments on commit 0ce23da

Please sign in to comment.