doc: remove vestigial onboarding section

The onboarding-extras doc includes a section with a single bullet point instructing the new Collaborator to write good pull request descriptions. This material is likely superfluous and is in the wrong document if it is not. (It more properly belongs in pull-requests.md as it is information that is not specific to new Collaborators.) I am not putting it in pullrequests.md because that document is already plenty long and detailed, and includes advice on writing good commit messages, which tend to become the pull request descriptions anyway. PR-URL: #21028 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Jun 6, 2018 · 09aec43 · 09aec43
1 parent fd201e0
commit 09aec43
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md
@@ -93,7 +93,3 @@ to update from nodejs/node:
 * `git checkout master`
 * `git remote update -p` OR `git fetch --all`
 * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
-
-## Best practices
-
-* When making PRs, spend time writing a thorough description.