test: fix flaky test-https-set-timeout-server

Because of a race condition, connection listener may not be invoked if test is run under load. Remove `common.mustCall()` wrapper from the listener. Move the test to `parallel` because it now works under load. Make similar change to http test to keep them in synch even though it is much harder to trigger the race in http. PR-URL: #14134 Fixes: #14133 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
nodejs · Jul 19, 2017 · 07a5b15 · 07a5b15
1 parent 7f2b5d3
commit 07a5b15
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/test/parallel/test-http-set-timeout-server.js b/test/parallel/test-http-set-timeout-server.js
@@ -42,9 +42,10 @@ function run() {
 }
 
 test(function serverTimeout(cb) {
-  const server = http.createServer(common.mustCall((req, res) => {
-    // just do nothing, we should get a timeout event.
-  }));
+  const server = http.createServer((req, res) => {
+    // Do nothing. We should get a timeout event.
+    // Might not be invoked. Do not wrap in common.mustCall().
+  });
   server.listen(common.mustCall(() => {
     const s = server.setTimeout(50, common.mustCall((socket) => {
       socket.destroy();

diff --git a/...quential/test-https-set-timeout-server.js → ...parallel/test-https-set-timeout-server.js b/...quential/test-https-set-timeout-server.js → ...parallel/test-https-set-timeout-server.js
@@ -54,9 +54,10 @@ function run() {
 test(function serverTimeout(cb) {
   const server = https.createServer(
     serverOptions,
-    common.mustCall((req, res) => {
-      // just do nothing, we should get a timeout event.
-    }));
+    (req, res) => {
+      // Do nothing. We should get a timeout event.
+      // Might not be invoked. Do not wrap in common.mustCall().
+    });
   server.listen(common.mustCall(() => {
     const s = server.setTimeout(50, common.mustCall((socket) => {
       socket.destroy();