test: validate fs.rename() when NODE_TEST_DIR on separate mount

When testing fs.rename() of an non-existent file, use a destination path which is in the same directory. Otherwise we might trigger an `EXDEV` error if NODE_TEST_DIR is a separate device than the current working directory. Fixes: #21669 PR-URL: #24707 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Nov 29, 2018 · 053f3d6 · 053f3d6
1 parent 68dc100
commit 053f3d6
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/test/parallel/test-fs-error-messages.js b/test/parallel/test-fs-error-messages.js
@@ -299,10 +299,11 @@ function re(literals, ...values) {
     return true;
   };
 
-  fs.rename(nonexistentFile, 'foo', common.mustCall(validateError));
+  const destFile = path.join(tmpdir.path, 'foo');
+  fs.rename(nonexistentFile, destFile, common.mustCall(validateError));
 
   assert.throws(
-    () => fs.renameSync(nonexistentFile, 'foo'),
+    () => fs.renameSync(nonexistentFile, destFile),
     validateError
   );
 }