events: add null check for the signal of EventTarget

This will improve the Web compatibility. Passing null as the signal should throw an error. WPT says "Passing null as the signal should throw". Please see https://github.com/web-platform-tests/wpt/blob/master/dom/events/AddEventListenerOptions-signal.any.js PR-URL: #43153 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 13, 2022 · 03fb789 · 03fb789
1 parent 4884746
commit 03fb789
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -34,7 +34,7 @@ const {
     ERR_INVALID_THIS,
   }
 } = require('internal/errors');
-const { validateObject, validateString, validateInternalField } = require('internal/validators');
+const { validateAbortSignal, validateObject, validateString, validateInternalField } = require('internal/validators');
 
 const {
   customInspectSymbol,
@@ -575,6 +575,8 @@ class EventTarget {
     }
     type = String(type);
 
+    validateAbortSignal(signal, 'options.signal');
+
     if (signal) {
       if (signal.aborted) {
         return;

diff --git a/test/parallel/test-whatwg-events-add-event-listener-options-signal.js b/test/parallel/test-whatwg-events-add-event-listener-options-signal.js
@@ -4,6 +4,7 @@ require('../common');
 
 const {
   strictEqual,
+  throws,
 } = require('assert');
 
 // Manually ported from: wpt@dom/events/AddEventListenerOptions-signal.any.js
@@ -157,3 +158,11 @@ const {
   }, { once: true });
   et.dispatchEvent(new Event('foo'));
 }
+{
+  const et = new EventTarget();
+  [1, 1n, {}, [], null, true, 'hi', Symbol(), () => {}].forEach((signal) => {
+    throws(() => et.addEventListener('foo', () => {}, { signal }), {
+      name: 'TypeError',
+    });
+  });
+}
diff --git a/test/wpt/status/dom/events.json b/test/wpt/status/dom/events.json
@@ -11,7 +11,6 @@
   "AddEventListenerOptions-signal.any.js": {
     "fail": {
       "expected": [
-        "Passing null as the signal should throw",
         "Passing null as the signal should throw (listener is also null)"
       ]
     }