lib: add unsubscribe method to non-active DC channels

PR-URL: #40433 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
nodejs · Jan 25, 2022 · 004eafb · 004eafb
1 parent 625be75
commit 004eafb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/doc/api/diagnostics_channel.md b/doc/api/diagnostics_channel.md
@@ -162,7 +162,7 @@ added:
 changes:
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/40433
-    description: Added return value.
+    description: Added return value. Added to channels without subscribers.
 -->
 
 * `onMessage` {Function} The previous subscribed handler to remove

diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js
@@ -81,6 +81,10 @@ class Channel {
     this.subscribe(subscription);
   }
 
+  unsubscribe() {
+    return false;
+  }
+
   get hasSubscribers() {
     return false;
   }