Need help to unbreak canary builds #69
Comments
|
Is d6f7a32 the conflicting change? I think it might be enough for now to remove the first part of the diff linked above in |
Yes.
You mean to not add the two lines in |
|
Ok, I’ll look into it … should be doable 🤞 (Edit: I need a debug build :/ This is going to take a while, maybe rather tomorrow or so …) |
|
Sorry about this! @addaleax Let me know if there is anything I can help out with. Thanks |
danbev
added a commit
to danbev/node-v8
that referenced
this issue
Jul 3, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs#69
|
@addaleax I took a look and have a suggestion linked above. Feel free to ignore you have already started looking into this. I did not mean to step on your toes here, just felt bad bad that you are having to spend time fixing issues that I caused. |
|
@danbev I’ll think about it in more detail (because we don’t seem to have a good story for this part of the API atm), but your fix definitely seems okay :) |
|
@targos Can you confirm that the linked patch works, at least as a temporary workaround? |
targos
pushed a commit
to nodejs/node
that referenced
this issue
Jul 13, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
|
Now, lkgr has advanced and I'm experiencing a new issue! I pushed the current state to canary-base: https://github.com/nodejs/node/commits/canary-base. Something related to ICU changed upstream, probably related to this commit: v8/v8@3ba5445#diff-4eaebbcd1dc0da11e3a3ce488290bfc6 Here is one of the errors I get: |
|
/cc @srl295 ? |
|
@addaleax i'm concerned about the unconditional inclusion of the |
|
I think I understand what the problem is. After that commit, when |
|
That makes sense. The v8 change is to move more stuff to C++.
more stuff off without ICU..
…On Fri, Jul 13, 2018 at 9:36 AM Michaël Zasso ***@***.***> wrote:
I think I understand what the problem is. After that commit, when
v8_enable_i18n_support is turned on, more targets need to include ICU,
similar to how it's done here for the main target:
https://github.com/nodejs/node/blob/45732c7c19672869a7e517e252c83b371a863bee/deps/v8/gypfiles/v8.gyp#L1820-L1824
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0Mszoz5oFGKyLik66DzxSNudp9FuHAks5uGMyggaJpZM4U_1ns>
.
|
|
/cc @nodejs/gyp Tentative fix: targos/node@adf23f2 Now I see this error: |
|
for reference, v8's bump to 62.1 https://chromium-review.googlesource.com/c/v8/v8/+/1111857#message-4f92f63a195703cf7cc65aea74efa2f9b8163f2d |
|
@targos i finally realized there's a |
targos
pushed a commit
to nodejs/node
that referenced
this issue
Jul 21, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
|
Ping @nodejs/v8-update. Would someone be able to help with this forward declaration issue? |
|
@targos I couldn’t reproduce that failure when building the current |
|
@addaleax you can try with |
diff --git a/src/heap_utils.cc b/src/heap_utils.cc
index 2d339c580fa0..ead3716daf44 100644
--- a/src/heap_utils.cc
+++ b/src/heap_utils.cc
@@ -76,7 +76,7 @@ class JSGraph : public EmbedderGraph {
return n;
}
- void AddEdge(Node* from, Node* to) override {
+ void AddEdge(Node* from, Node* to, const char* name) override {
edges_[from].insert(to);
}
diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp
index a50f12d7940b..2acc95b409b8 100644
--- a/tools/icu/icu-generic.gyp
+++ b/tools/icu/icu-generic.gyp
@@ -32,7 +32,6 @@
'direct_dependent_settings': {
'defines': [
'UCONFIG_NO_SERVICE=1',
- 'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
'U_ENABLE_DYLOAD=0',
'U_STATIC_IMPLEMENTATION=1',
'U_HAVE_STD_STRING=1',seems to do the trick for me on your branch 🎉 |
|
Awesome, thank you! I had to fix a few other things but finally got it to compile :) Update build: https://ci.nodejs.org/view/MyJobs/job/node-update-v8-canary/531/console |
nodejs-ci
pushed a commit
that referenced
this issue
Jul 21, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
|
The canary is back! |
nodejs-ci
pushed a commit
that referenced
this issue
Jul 22, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Jul 23, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Aug 27, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
nodejs-ci
pushed a commit
that referenced
this issue
Aug 28, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Aug 28, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Aug 29, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Aug 30, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Aug 31, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Aug 31, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Aug 31, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Aug 31, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 1, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 1, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 1, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 2, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 2, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 2, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 3, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 4, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 4, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 5, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 5, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 5, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
nodejs-ci
pushed a commit
that referenced
this issue
Sep 6, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: #69
targos
pushed a commit
to nodejs/node
that referenced
this issue
Sep 7, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to targos/node
that referenced
this issue
Sep 7, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69
targos
pushed a commit
to targos/node
that referenced
this issue
Sep 7, 2018
This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69 PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The canary branch is currently broken because 714c686#diff-91081f7e2c43274462308861f4191e3b is no longer valid after recent changes to
test/cctest/node_test_fixture.hon master.Would someone be able to help me unbreak it?
The text was updated successfully, but these errors were encountered: