util: add type check function for BigIntObject

Also exclude isBigInt from test because `typeof value === 'bigint'` can be used instead.
nodejs · Mar 29, 2018 · 1dcce92 · 1dcce92
1 parent 070ed3e
commit 1dcce92
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/node_types.cc b/src/node_types.cc
@@ -13,6 +13,7 @@ namespace {
   V(External)                                                                 \
   V(Date)                                                                     \
   V(ArgumentsObject)                                                          \
+  V(BigIntObject)                                                             \
   V(BooleanObject)                                                            \
   V(NumberObject)                                                             \
   V(StringObject)                                                             \

diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml
@@ -21,5 +21,6 @@ rules:
 # Global scoped methods and vars
 globals:
   WebAssembly: false
+  BigInt: false
   BigInt64Array: false
   BigUint64Array: false
diff --git a/test/parallel/test-util-types.js b/test/parallel/test-util-types.js
@@ -23,6 +23,7 @@ for (const [ value, _method ] of [
   [ new Number(), 'isNumberObject' ],
   [ new String(), 'isStringObject' ],
   [ Object(Symbol()), 'isSymbolObject' ],
+  [ Object(BigInt(0)), 'isBigIntObject' ],
   [ new Error(), 'isNativeError' ],
   [ new RegExp() ],
   [ async function() {}, 'isAsyncFunction' ],
@@ -148,7 +149,7 @@ try {
 const exclude = [
   'Undefined', 'Null', 'NullOrUndefined', 'True', 'False', 'Name', 'String',
   'Symbol', 'Function', 'Array', 'Object', 'Boolean', 'Number', 'Int32',
-  'Uint32'
+  'Uint32', 'BigInt'
 ];
 
 const start = v8_h.indexOf('Value : public Data');