This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Update path.extname documentation #8509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an additional example to `path.extname` to demonstrate the case where the first letter of the last path component is `'.'`. This case is an interesting one, as `path.extname('.txt')`, returns an empty string. In this case, `.txt` is a potentially valid file name with some semantic value as a text file (while arguably maintaining an extension). I agree with Node's behavior in this case, but I think the added example provides clarity on the method's behavior.
|
LGTM @chrisdickinson feel free to fix the commit message and land. |
|
Closing this here. New PR opened. |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#8509 originally submitted by @thauburger Adding an additional example to path.extname documentation to demonstrate the case where the first character of the last path component is '.'. This case is interesting, as something like path.extname('.txt') returns an empty string. In this case, .txt can be used as a valid file name (while arguably maintaining an extension). I agree with Node's behavior in this case, but I think the added example provides additional clarity for the developer.
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#8509 originally submitted by @thauburger Adding an additional example to path.extname documentation to demonstrate the case where the first character of the last path component is '.'. This case is interesting, as something like path.extname('.txt') returns an empty string. In this case, .txt can be used as a valid file name (while arguably maintaining an extension). I agree with Node's behavior in this case, but I think the added example provides additional clarity for the developer. Reviewed By: Sakthipriyan Vairamani <[email protected]> PR-URL: #2378
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#8509 originally submitted by @thauburger Adding an additional example to path.extname documentation to demonstrate the case where the first character of the last path component is '.'. This case is interesting, as something like path.extname('.txt') returns an empty string. In this case, .txt can be used as a valid file name (while arguably maintaining an extension). I agree with Node's behavior in this case, but I think the added example provides additional clarity for the developer. Reviewed By: Sakthipriyan Vairamani <[email protected]> PR-URL: #2378
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an additional example to
path.extnamedocumentation to demonstrate the case where the first character of the last path component is'.'. This case is interesting, as something likepath.extname('.txt')returns an empty string. In this case,.txtcan be used as a valid file name (while arguably maintaining an extension). I agree with Node's behavior in this case, but I think the added example provides additional clarity for the developer.