This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
net: Ensure consistent binding to IPV6 if address is absent #7683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| handle.close(); | ||
| // Fallback to ipv4 | ||
| return createServerHandle('0.0.0.0', port); | ||
| } |
There was a problem hiding this comment.
Duplicates the logic at lines 1084-1090. Can you find a way to unify both blocks?
See nodejs#7675 net.server.listen() behaves inconsistently depending on whether the port number is provided. 1. port === 0 && host == '' (i.e. false-y), node creates an AF_INET socket but does not call bind(). 2. port > 0 && host == '', node creates an AF_INET6 socket and calls bind(). The fix makes 1 consistent with 2.
|
@bnoordhuis Thank you for review. The issues you raised should have been fixed now. |
|
LGTM, running tests |
|
Thank you very much, landed in 57c5655 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7675:
net.server.listen() behaves inconsistently depending on whether the port
number is provided.
socket but does not call bind().
bind().
The fix makes 1 consistent with 2.