Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

crypto: Show exponent in decimal and hex #25674

Closed
wants to merge 1 commit into from
Closed

crypto: Show exponent in decimal and hex #25674

wants to merge 1 commit into from

Conversation

iamthechad
Copy link

Show the exponent in a manner that matches OpenSSL
Fixes #17202

Show the exponent in a manner that matches OpenSSL
Fixes #17202
@jasnell
Copy link
Member

jasnell commented Aug 6, 2015

Definitely can appreciate the intent on this, but it does involve a bit of an API change, which we should likely avoid in v0.12 and v0.10. This should likely be targeted at http://github.com/nodejs/io.js or http://github.com/nodejs/node instead.

@jasnell jasnell added the crypto label Aug 6, 2015
@iamthechad
Copy link
Author

I'll admit I don't know much about the timelines around which repo to use when. Are future changes not going to be applied to this repo any more? We knew this was a breaking change, which is why it's targeted at master and not a specific release.

@jasnell
Copy link
Member

jasnell commented Aug 6, 2015

For breaking changes, we want to target nodejs/io.js or nodejs/node as that is where the next major release will come from. joyent/node is largely intended for LTS of the v0.12 and v.10 streams.

@iamthechad
Copy link
Author

Okay. Is there a preference as to which repo - nodejs/iojs vs nodejs/node?

@jasnell
Copy link
Member

jasnell commented Aug 6, 2015

Likely io.js would be best.
On Aug 6, 2015 1:55 PM, "Chad Johnston" [email protected] wrote:

Okay. Is there a preference as to which repo - nodejs/iojs vs nodejs/node?


Reply to this email directly or view it on GitHub
#25674 (comment).

@iamthechad
Copy link
Author

Resubmitted to io.js. Should this PR be closed?

@jasnell
Copy link
Member

jasnell commented Aug 7, 2015

Yes, thank you!

@jasnell jasnell closed this Aug 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants