-
Notifications
You must be signed in to change notification settings - Fork 7.3k
test: pausing and resuming stdin
prevents auto-termination
#1934
Conversation
Confirmed. Issue can be reduced to |
Problems seem to be libuv related only: ./node -e "new (process.binding('tty_wrap').TTY)(-1, true)" |
Or to be even more exact: ./node -e "new require('net').Socket(0)" |
@bnoordhuis, can you please pull that so that it becomes an actual problem instead of "that guy over there said it doesn't work"? |
+1, this is causing problems with my getpass implementation |
Yes, but can you rewrite the test so that it doesn't spawn a new process? |
This works on `node v0.4.12`, but doesn't work on `node v0.6.2`
Ah, using child process for that was in fact retarded. Done. |
Thanks, Maciej. Merged in master in 3f862cf. I'll backport it to v0.6 once a fix is out that doesn't require an API change (not likely but still). |
Thanks. Should I open an issue about this test failing? |
There's no real need but go ahead if you want something to track. |
@mmalecki did you open another issue for this? I'd like something to track |
@mmalecki thanks |
This works on
node v0.4.12
, but doesn't work onnode v0.5.10
.This breaks apps which use
process.stdin.resume()
andprocess.stdin.pause()
(it doesn't allow them to automatically terminate; such app has to callprocess.exit
in order to exit).