This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
test/simple/test-fs-access.js fails most of the time #9033
Comments
|
The problem is that when running I'm currently trying to think of some way to fix that cleanly. |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jan 16, 2015
On non-windows supported platforms, fs.access(readOnlyFile, W_OK, ...) is expected to fail, but always succeeds if node runs as the super user, which is often the case for tests running on our continuous integration platform. This change makes the test try to change its process user id to nobody on non-windows platforms so that the above mentioned test can pass and still perform the actual desired test. If changing the process user id to a nobody is not possible, then the test checks that fs.access(readOnlyFile, W_OK, ...) actually succeeds. Fixes nodejs#9033.
|
Fixed by #9039. |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jan 16, 2015
On non-windows supported platforms, fs.access(readOnlyFile, W_OK, ...) is expected to fail, but always succeeds if node runs as the super user, which is often the case for tests running on our continuous integration platform. This change makes the test try to change its process user id to nobody on non-windows platforms so that the above mentioned test can pass and still perform the actual desired test. If changing the process user id to a nobody is not possible, then the test checks that fs.access(readOnlyFile, W_OK, ...) actually succeeds. Fixes nodejs#9033.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jan 16, 2015
On non-windows supported platforms, fs.access(readOnlyFile, W_OK, ...) is expected to fail, but always succeeds if node runs as the super user, which is often the case for tests running on our continuous integration platform. This change makes the test try to change its process user id to nobody on non-windows platforms so that the above mentioned test can pass and still perform the actual desired test. If changing the process user id to a nobody is not possible, then the test checks that fs.access(readOnlyFile, W_OK, ...) actually succeeds. Fixes nodejs#9033. Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy J Fontaine <[email protected]>
|
Landed fix in 28d0cbb. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For instance: http://jenkins.nodejs.org/job/nodejs-v0.12/DESTCPU=ia32,label=ubuntu-12.04/lastBuild/tapTestReport/simple.tap-196/.
It seems it passes all the time on Windows, and sometimes passes on other platforms though.
The text was updated successfully, but these errors were encountered: