url resolve(href, '.') sometimes leaves off trailing slash #8992

blatx · 2015-01-07T22:01:01Z

The following script:

var url = require('url');
console.log(url.resolve('http://www.example.com/path/to/edit', 'view'));
console.log(url.resolve('/path/to/edit', 'view'));
console.log(url.resolve('http://www.example.com/path/to/edit', '.'));
console.log(url.resolve('/path/to/edit', '.'));

produces the following output:

http://www.example.com/path/to/view
/path/to/view
http://www.example.com/path/to/
/path/to

which is: resolving '.' produces a result that contains a trailing slash if the base url is absolute including host, but leaves it off if there is no host name (AKA "relative to the domain root").

These are very different urls both for a webserver and as a base url for a browser.

On every browser I have tested, using the following html

<html>
<head>
<base href="/path/to/edit" />
</head>
<body>
<a href="." onclick="alert(this.href); return false">test</a>
</body>
</html>

the href of the test link also always includes the slash.

Tested with v0.10.35

The text was updated successfully, but these errors were encountered:

amir-s · 2015-01-08T07:35:06Z

I'm not sure if this is a bug or not.
In the source code (https://github.com/joyent/node/blob/master/lib/url.js#L473) it is mentioned: "urlParse appends trailing / to urls like http://www.example.com"

blatx · 2015-01-08T12:01:53Z

"http://www.example.com" and "http://www.example.com/" represent the exact same thing: the root in the domain. This is something else.

I found the following comment and code in the same file you pointed to:

  // if a url ENDs in . or .., then it must get a trailing slash.
  // however, if it ends in anything else non-slashy,
  // then it must NOT get a trailing slash.
  var last = srcPath.slice(-1)[0];
  var hasTrailingSlash = (
      (result.host || relative.host) && (last === '.' || last === '..') ||
      last === '');

I'm sure the "bug" is in that test for the host in (result.host || relative.host). I see no good reason at all to let that behaviour depend on whether a host as provided, or not. There is no well-known browser in the world that behaves that way, and compatibility with browser behaviour is supposed to be a very high priority for this module.

"." and ".." are directory specs, "/path/to/" is a directory spec, but "/path/to" is not.

Hence, the trailing slash should always be there.

amir-s · 2015-01-10T00:20:51Z

You are right.

Actually url.resolve('/blah', '.') produces an empty string too, which should produce /.

I managed to solve the problem on my machine. I'll send a pull request.

'.' and '..' are directory specs and resloving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fix nodejs#8992

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fix nodejs#8992

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes: #8992 PR-URL: #9010 Reviewed-by: Trevor Norris <[email protected]>

trevnorris · 2015-02-09T21:50:36Z

Fixed by ad06848.

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes: nodejs/node-v0.x-archive#8992 PR-URL: #278 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes: nodejs#8992 PR-URL: nodejs#9010 Reviewed-by: Trevor Norris <[email protected]>

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes nodejs#8992.

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes #8992. Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #9427

misterdjules · 2015-03-17T21:57:06Z

Just for the record, this actually landed for good in 9b534e2.

amir-s added a commit to amir-s/node that referenced this issue Jan 11, 2015

url: reslove urls with . and ..

1db28ef

'.' and '..' are directory specs and resloving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fix nodejs#8992

amir-s added a commit to amir-s/node that referenced this issue Jan 11, 2015

url: reslove urls with . and ..

3f99a92

'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fix nodejs#8992

amir-s mentioned this issue Jan 11, 2015

url: reslove urls with . and .. #9010

Closed

trevnorris closed this as completed Feb 9, 2015

misterdjules mentioned this issue Mar 17, 2015

url: resolve urls with . and .. #9427

Closed

misterdjules self-assigned this Mar 17, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

url resolve(href, '.') sometimes leaves off trailing slash #8992

url resolve(href, '.') sometimes leaves off trailing slash #8992

blatx commented Jan 7, 2015

amir-s commented Jan 8, 2015

blatx commented Jan 8, 2015

amir-s commented Jan 10, 2015

trevnorris commented Feb 9, 2015

misterdjules commented Mar 17, 2015

url resolve(href, '.') sometimes leaves off trailing slash #8992

url resolve(href, '.') sometimes leaves off trailing slash #8992

Comments

blatx commented Jan 7, 2015

amir-s commented Jan 8, 2015

blatx commented Jan 8, 2015

amir-s commented Jan 10, 2015

trevnorris commented Feb 9, 2015

misterdjules commented Mar 17, 2015