Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More verbose error on locating msbuild.exe failure #930

Closed
wants to merge 1 commit into from

Conversation

purplecode
Copy link
Contributor

The first error usage was misleading. In my case the error was saying 'Access denied' and it was because of limited privileges, not because of missing VS installation. It was also hard to debug because one of the deeply nested dependencies was failing.

@bnoordhuis
Copy link
Member

LGTM but you show up as "purplecode" in the commit's Author field. Want me to land it under your real name?

Also, if you can reword the commit log so it conforms a bit better to the general format we use, that would be great.

@purplecode
Copy link
Contributor Author

I rewrote the author field and commit message in my commit

@purplecode purplecode changed the title findMsbuild - better error handling gyp: more verbose error on locating msbuild.exe failure May 31, 2016
@purplecode purplecode changed the title gyp: more verbose error on locating msbuild.exe failure More verbose error on locating msbuild.exe failure May 31, 2016
bnoordhuis pushed a commit that referenced this pull request Jun 2, 2016
@bnoordhuis
Copy link
Member

Thanks Mateusz, landed in a4fa07b. I massaged the commit log's status line so it fit in 50 columns.

@bnoordhuis bnoordhuis closed this Jun 2, 2016
@rvagg rvagg mentioned this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants