gyp: fix android generator #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating Android .mk files, ready to be used within Android build system, we don't need LOCAL_SDK_VERSION specified, since the Android build system already uses the latest one. By specifying LOCAL_SDK_VERSION in Android makefiles, the build using Android build system will fail, because the build system won't set the path to stlport from prebuilts. Signed-off-by: Robert Chiras <[email protected]>
bnoordhuis
pushed a commit
that referenced
this pull request
Mar 4, 2016
When generating Android .mk files, ready to be used within Android build system, we don't need LOCAL_SDK_VERSION specified, since the Android build system already uses the latest one. By specifying LOCAL_SDK_VERSION in Android makefiles, the build using Android build system will fail, because the build system won't set the path to stlport from prebuilts. Signed-off-by: Robert Chiras <[email protected]> PR-URL: #889 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Robert, landed in a981ef8 and released as v3.3.1. |
|
Also, /cc @othiym23. |
|
Thanks for the heads up, @bnoordhuis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating Android .mk files, ready to be used within Android build
system, we don't need LOCAL_SDK_VERSION specified, since the Android
build system already uses the latest one.
By specifying LOCAL_SDK_VERSION in Android makefiles, the build using
Android build system will fail, because the build system won't set the
path to stlport from prebuilts.
Signed-off-by: Robert Chiras [email protected]
Note: This patch is very useful to help integrate node into an Android build system, mostly used by vendors when generating their products. I know the android generator is not maintained anymore, but fixing this generator is crucial for building node as target in an Android build system.