Use stdio instead of customFds #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
added a commit
that referenced
this pull request
Nov 11, 2014
…ning Use stdio instead of customFds
|
Thanks! |
3 tasks
This was referenced Mar 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the noisy deprecation warnings when node-gyp is used with >= node v0.11.14. Apparently the
stdiooption has been around andcustomFdshas been deprecated since node v0.5.11 (nodejs/node-v0.x-archive@2454695).Would love to see this land since for node-pre-gyp I test expected stdout and stderr and therefore this deprecation warning breaks my tests against node v0.11.14: https://travis-ci.org/mapbox/node-pre-gyp/builds/40707288