-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: drop Python 2 support in find-python.js #2333
lib: drop Python 2 support in find-python.js #2333
Commits on Feb 15, 2021
-
lib: drop Python 2 support in find-python.js
Python 2 isn't supported in gyp-next anymore, so we should stop finding/trying to use Python 2.
Configuration menu - View commit details
-
Copy full SHA for a9e3219 - Browse repository at this point
Copy the full SHA a9e3219View commit details -
test: test find-python against supported Python 3
Note: This commit is required for the previous commit to pass tests. I have left it separate for clarity during review of this PR. But it should be squashed with the previous commit if/when merging.
Configuration menu - View commit details
-
Copy full SHA for 83bf041 - Browse repository at this point
Copy the full SHA 83bf041View commit details -
Revert "lib: drop "-2" flag for "py.exe" launcher"
This reverts commit c255ffb. Note: My intent here is not to actually restore any Python 2 support, just to make it clearer where the comment text originally came from. It would be fair to squash this with the next commit if/when merging.
Configuration menu - View commit details
-
Copy full SHA for 39403a8 - Browse repository at this point
Copy the full SHA 39403a8View commit details -
lib: use "-3" flag with py.exe launcher
Ensures the py.exe launcher only finds Python 3. (Only applies to Windows users.)
Configuration menu - View commit details
-
Copy full SHA for 9c0d980 - Browse repository at this point
Copy the full SHA 9c0d980View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c48f70 - Browse repository at this point
Copy the full SHA 3c48f70View commit details
Commits on Feb 16, 2021
-
lib: accept python '>=3.6.0' in find-python.js
Co-authored-by: Christian Clauss <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f13747d - Browse repository at this point
Copy the full SHA f13747dView commit details
Commits on Feb 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d1f2aec - Browse repository at this point
Copy the full SHA d1f2aecView commit details
Commits on Feb 18, 2021
-
test: update Python path for "good guess" test
Note: This is required for the previous commit to pass tests. Please squash this with the previous commit if/when merging.
Configuration menu - View commit details
-
Copy full SHA for 2562153 - Browse repository at this point
Copy the full SHA 2562153View commit details -
lib: use correct paths for 32-bit system-wide Python
Paths are installed with a "-32" suffix: "Python[version]-32" I forgot to add the "-32" in previous commits. Note: It would be good to squash this with the previous two commits.
Configuration menu - View commit details
-
Copy full SHA for d20f929 - Browse repository at this point
Copy the full SHA d20f929View commit details -
lib: add system-wide Python path for 32-bit Windows
32-bit Windows doesn't have a "Program Files (x86)" folder, only "Program Files".
Configuration menu - View commit details
-
Copy full SHA for 54041d8 - Browse repository at this point
Copy the full SHA 54041d8View commit details -
lib: construct winDefaultLocations programatically
Reduces boilerplate code. Also, refactored to drop the dependency on the 'path' module.
Configuration menu - View commit details
-
Copy full SHA for d0bcb5c - Browse repository at this point
Copy the full SHA d0bcb5cView commit details
Commits on Feb 22, 2021
-
lib: assign localAppData and programFiles from env
These paths may be localized to other languages, or placed on another drive. (These paths appear to be mostly standardized on Windows 10, but they can apparently be relocated on Windows Server, and may be localized on some older version(s) of Windows.)
Configuration menu - View commit details
-
Copy full SHA for a7b43aa - Browse repository at this point
Copy the full SHA a7b43aaView commit details -
lib: fall back to os.userInfo() to get username
This should be a reliable fallback in case the environment variables have been deleted or unset.
Configuration menu - View commit details
-
Copy full SHA for 432447d - Browse repository at this point
Copy the full SHA 432447dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1711046 - Browse repository at this point
Copy the full SHA 1711046View commit details -
test: adjust expected number of tests
Note: This fixes an oversight in the previous commit, and is required for the previous commit to pass tests. Please squash this with the previous commit if/when merging.
Configuration menu - View commit details
-
Copy full SHA for ec64f91 - Browse repository at this point
Copy the full SHA ec64f91View commit details