ci: switch to GitHub Actions #2127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
swap-to-actions
branch
9 times, most recently
from
2d5d02b
to
2f0cfca
Compare
|
Not 100% sure why the windows tests are failing 🤔 i copied pretty directly from the travis file. |
codebytere
force-pushed
the
swap-to-actions
branch
2 times, most recently
from
2702bb3
to
c27850c
Compare
|
Just use the same code that you use for the real operating systems. That should work. |
codebytere
force-pushed
the
swap-to-actions
branch
from
c27850c
to
66cef25
Compare
|
On Windows you should be able to use |
codebytere
force-pushed
the
swap-to-actions
branch
from
66cef25
to
55580aa
Compare
codebytere
force-pushed
the
swap-to-actions
branch
from
55580aa
to
4c3d33d
Compare
cclauss
reviewed
May 15, 2020
cclauss
reviewed
May 15, 2020
codebytere
force-pushed
the
swap-to-actions
branch
5 times, most recently
from
25e5a4c
to
8ea1131
Compare
cclauss
reviewed
May 15, 2020
.github/workflows/test.yml
Outdated
| uses: microsoft/[email protected] | ||
| - name: Install Dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip flake8 pytest==4.6.6 |
There was a problem hiding this comment.
Why hardcore pytest to a low version?
There was a problem hiding this comment.
i pulled it from the python examples used in stock python GitHub Actions - I'll remove it.
codebytere
force-pushed
the
swap-to-actions
branch
2 times, most recently
from
702af88
to
8e0a956
Compare
codebytere
force-pushed
the
swap-to-actions
branch
2 times, most recently
from
614b28f
to
8aaf8b4
Compare
codebytere
force-pushed
the
swap-to-actions
branch
from
8aaf8b4
to
3cedd7e
Compare
gengjiawen
reviewed
May 21, 2020
| fail-fast: false | ||
| matrix: | ||
| node: [10.x, 12.x, 14.x] | ||
| python: [2.7, 3.6, 3.7, 3.8] |
There was a problem hiding this comment.
Maybe remove 2.7 since it's EOL
This was referenced Aug 31, 2020
rvagg
pushed a commit
that referenced
this pull request
Oct 14, 2020
Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: Matias Lopez <[email protected]> PR-URL: #2210 Closes: #2127 Closes: #2209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR switches test builds from Travis to GitHub Actions.
cc @rvagg @cclauss
Checklist
npm install && npm testpasses