Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Add Python 3.5 and 3.6 tests on Linux #1903

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 2, 2019

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@sam-github
Copy link
Contributor

https://github.com/nodejs/node-gyp#on-unix should be updated

I think this should be done, older ubuntu's only have py 3.5, and the docs say it "may" work, might as well add some tests to ensure that it does work, and continues to work.

@cclauss cclauss added the Python label Oct 2, 2019
@rvagg
Copy link
Member

rvagg commented Oct 3, 2019

landed in f60ed47

@rvagg rvagg closed this Oct 3, 2019
@rvagg rvagg deleted the Travis-CI-add-Python-3.5-and-3.5 branch October 3, 2019 01:16
rvagg pushed a commit that referenced this pull request Oct 3, 2019
Support the same Python versions as the Python Core Team: https://devguide.python.org/#branchstatus

PR-URL: #1903
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This was referenced Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants