-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: update to standard@14 #1899
Conversation
@@ -1,3 +1,5 @@ | |||
/* eslint-disable node/no-deprecated-api */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url.resolve()
and url.parse()
are used in here. I'm not entirely comfortable switching over fully to URL
yet, it took a little while to stabilise, so maybe not until we want to drop support for Node 8, or until Node starts printing deprecation warnings to stdout.
Are there formatter directives like Python Black's # fmt: off and # fmt: on so we can use sparingly to preserve your array artistry? |
Conflicts to resolve. |
43dfdbd
to
0d0e3f6
Compare
resolved.
No, intentionally so. The purpose of |
Agreed. Same philosophy behind the Python Software Foundation’s Black... You can have any color you want as long as it is Black. ;-) |
landed in 3555ff4 |
PR-URL: #1899 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #1899 Reviewed-By: João Reis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This mainly undoes all of my nice, consistent array spacing. They fell down on the (erroneous IMO) side of no spaces either side of square brackets, regardless of their use. Unnecessary quoting of array/object properties is also now checked.