Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: update to standard@14 #1899

Closed
wants to merge 1 commit into from
Closed

src: update to standard@14 #1899

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 30, 2019

This mainly undoes all of my nice, consistent array spacing. They fell down on the (erroneous IMO) side of no spaces either side of square brackets, regardless of their use. Unnecessary quoting of array/object properties is also now checked.

@@ -1,3 +1,5 @@
/* eslint-disable node/no-deprecated-api */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url.resolve() and url.parse() are used in here. I'm not entirely comfortable switching over fully to URL yet, it took a little while to stabilise, so maybe not until we want to drop support for Node 8, or until Node starts printing deprecation warnings to stdout.

@cclauss
Copy link
Contributor

cclauss commented Sep 30, 2019

undoes all of my nice, consistent array spacing

Are there formatter directives like Python Black's # fmt: off and # fmt: on so we can use sparingly to preserve your array artistry?

@cclauss
Copy link
Contributor

cclauss commented Sep 30, 2019

Conflicts to resolve.

@rvagg
Copy link
Member Author

rvagg commented Sep 30, 2019

resolved.

Are there formatter directives like Python Black's # fmt: off and # fmt: on so we can use sparingly to preserve your array artistry?

No, intentionally so. The purpose of standard is to provide a uniform standard that everyone can get on board with. We make a pact with each other to let go of most of our syntax preferences and accept standard as close-enough to what we like and just roll with it, removing most of the syntax arguing that's taken up so much GitHub comment space over the years. IMO the [] decision was short-sighted but I'm already putting up with it in many other projects and just getting on with the important work.

@cclauss
Copy link
Contributor

cclauss commented Sep 30, 2019

Agreed. Same philosophy behind the Python Software Foundation’s Black... You can have any color you want as long as it is Black. ;-)

@cclauss cclauss mentioned this pull request Sep 30, 2019
4 tasks
@rvagg rvagg mentioned this pull request Oct 2, 2019
@rvagg rvagg closed this Oct 2, 2019
@rvagg rvagg deleted the rvagg/standard14 branch October 2, 2019 03:53
@rvagg
Copy link
Member Author

rvagg commented Oct 2, 2019

landed in 3555ff4

rvagg added a commit that referenced this pull request Oct 2, 2019
PR-URL: #1899
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg added a commit that referenced this pull request Oct 2, 2019
PR-URL: #1899
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@rvagg rvagg mentioned this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants