-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved "unmanaged" handling for delay loading #1852
Conversation
Used scoped disabling of managed code handling to ensure no other files get affected.
The change looks reasonable to me, from what I understand of the docs it should have the same effect as what is there now. @peter-sabath I expected the unmanaged pragma to be effective only within this compilation unit. How does this affect other files? Is it a stateful thing in the compiler or does it actually become a runtime setting? @ipetrovic11 please let me know if this causes any issue to you. |
@joaocgreis You most likely are right, that only the current compilation unit is affected, but as good practice I use those |
@joaocgreis just tested, works fine for me with this improvement as well. @peter-sabath if you believe they will do something like that, I am pretty sure they will be handling solutions like first one, since they would break a lot of projects :) |
@ipetrovic11 This was just my way of solving it. We ran into the |
Used scoped disabling of managed code handling to ensure no other files get affected. PR-URL: #1852 Reviewed-By: João Reis <[email protected]>
Landed in af876e1. Thanks! |
Used scoped disabling of managed code handling to ensure no other files get affected. PR-URL: #1852 Reviewed-By: João Reis <[email protected]>
Checklist
npm install && npm test
passesDescription of change
Used scoped disabling of
managed
code handling to ensure no other files get affected.