bin,lib: remove extra comments/lines/spaces #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes "module dependencies" comments and things that, IMHO, don't add too much value. Happy to add back if helps some people when reading through `node-gyp`. - DRY up `lib/process-release.js`. - Removes a bunch of extra blank lines, as well as random spaces.
richardlau
reviewed
Jul 19, 2018
| @@ -126,7 +118,6 @@ process.on('uncaughtException', function (err) { | |||
| }) | |||
|
|
|||
| function errorMessage () { | |||
| // copied from npm's lib/util/error-handler.js | |||
There was a problem hiding this comment.
This is sort of an attribution (although the current path in npm now appears to be lib/utils/error-handler.js), so maybe keep?
richardlau
approved these changes
Jul 19, 2018
|
updated @richardlau, PTAL |
richardlau
approved these changes
Jul 26, 2018
|
Landed in 6b0f4ae, thank you for the review! |
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
- Removes "module dependencies" comments and things that, IMHO, don't add too much value. Happy to add back if helps some people when reading through `node-gyp`. - DRY up `lib/process-release.js`. - Removes a bunch of extra blank lines, as well as random spaces. PR-URL: #1508 Reviewed-By: Richard Lau <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
too much value. Happy to add back if helps some people when reading
through
node-gyp.lib/process-release.js.