Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I had trouble finding the Windows build tools. Fixed broken link in README.md #1392

Closed
wants to merge 2 commits into from

Conversation

rpfister51
Copy link

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@bzoz
Copy link
Contributor

bzoz commented Mar 19, 2018

Current link works on my box.

@rpfister51
Copy link
Author

Okay. The link is not "broken". But it leads to a non-specific page. By non-specific I mean that it leads to a page that has no "Default Install" option, but instead a link "Download Build Tools for Visual Studio 2017". That link leads to a page with 22 download buttons, non of which say "Default Install." One of these does say "Build Tools for Visual Studio 2017" which probably works; that doesn't happen to be the route I took in the end. I was trying to be helpful. I think the current link, and it's description in README.md should be better.

@maclover7
Copy link
Contributor

@rvagg
Copy link
Member

rvagg commented Aug 9, 2018

#1490

@rvagg rvagg closed this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants