Fix IndexError when parsing GYP files. #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Aug 20, 2017
|
@bnoordhuis you want to upstream it? |
gibfahn
approved these changes
Aug 21, 2017
GYP automatically turns variables ending in _dir, _file or _path into absolute paths but didn't check for empty strings. It interacted badly with variables inherited through the environment from npm, the `scripts-prepend-node-path=false` setting in particular because it is turned into `npm_config_script_prepend_node_path=`. Fixes: #1217 PR-URL: #1267 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Do you think it's useful? It's not like we pull in changes from upstream anymore. |
I try to for node core. And there's #1183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GYP automatically turns variables ending in _dir, _file or _path into
absolute paths but didn't check for empty strings.
It interacted badly with variables inherited through the environment
from npm, the
scripts-prepend-node-path=falsesetting in particularbecause it is turned into
npm_config_script_prepend_node_path=.Fixes: #1217
CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/32/