Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated dependency warning #1069

Closed
wants to merge 1 commit into from
Closed

Conversation

simonepri
Copy link

screenshot- 34
node-gyp installs [email protected]
[email protected] installs [email protected]

[email protected] uses [email protected] that is been ranamed to supports-color

The warning is not showed if we tell node-gyp to use [email protected]
[email protected] installs [email protected] that fix the dependency warnings.

See https://github.com/iarna/gauge/pull/77

screenshot- 33

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fishrock123 pushed a commit that referenced this pull request Dec 15, 2016
Refs: https://github.com/iarna/gauge/pull/77
PR-URL: #1069
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123
Copy link
Contributor

Thanks, landed in 80fc5c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants