Is there any way to use C++17 on MSBuild? #1662

Akarinnnnn · 2019-02-07T16:05:11Z

Node Version:10.15.0
Platform:Windows 10 x64
Compiler:MSBuild ,toolset v150
Module:my SVLauncherDLL

Verbose output (from npm or node-gyp):

e:\visual studio项目\dsted\source\cpp-addon\svlaunchdll_jswrap.cc(135): error C7525: 内联变量至少需要 "/std:c++17" (编译源文件 ..\cpp-
addon\svlaunchdll_jswrap.cc) [E:\Visual Studio项目\DSTed\Source\build\SVLaunchDLL.vcxproj]

I need C++17, seriously.

cpp-addon.zip

refack · 2019-02-07T16:18:46Z

Add the following to your binding.gyp:

  'msvs_settings': {
    'VCCLCompilerTool': {
      'AdditionalOptions': [ '-std:c++17', ],
    },
  },

Akarinnnnn · 2019-02-07T17:24:53Z

Failed

Traceback (most recent call last):
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\gyp_main.py", line 16, in <module>
    sys.exit(gyp.script_main())
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 545, in script_main
    return main(sys.argv[1:])
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 538, in main
    return gyp_main(args)
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 514, in gyp_main
    options.duplicate_basename_check)
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 130, in Load
    params['parallel'], params['root_targets'])
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 2783, in Load
    variables, includes, depth, check, True)
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 399, in LoadTargetBuildFile
    includes, True, check)
  File "E:\NPM_PREFIX\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 251, in LoadOneBuildFile
    None)
  File "binding.gyp", line 23
    'msvs-settings':
                  ^
SyntaxError: invalid syntax

binding.gyp.txt

refack · 2019-02-07T18:30:11Z

replace [ with { for 'msvs_settings' and 'VCCLCompilerTool'
binding.gyp.txt

Akarinnnnn · 2019-02-08T11:03:28Z

Verbose output (from npm or node-gyp):

Traceback (most recent call last): File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\gyp_main.py", line 16, in sys.exit(gyp.script_main()) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 545, in script_main return main(sys.argv[1:]) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 538, in main return gyp_main(args) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 514, in gyp_main options.duplicate_basename_check) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\__init__.py", line 130, in Load params['parallel'], params['root_targets']) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 2783, in Load variables, includes, depth, check, True) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 425, in LoadTargetBuildFile build_file_data, PHASE_EARLY, variables, build_file_path) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 1293, in ProcessVariablesAndConditionsInDict build_file, key) File "E:\NPM_PREFIX\node_modules\prebuild\node_modules\node-gyp\gyp\pylib\gyp\input.py", line 1303, in ProcessVariablesAndConditionsInDict ' for ' + key) TypeError: Unknown type set for AdditionalOptions while trying to load binding.gyp

binding.gyp.txt

i had changed binding.gyp as you said, but it does not work

rvagg · 2019-06-20T06:07:28Z

please try and use Refael's exact syntax:

			'msvs-settings':
			{
				'VCCLCompilerTool':
				{
					'AdditionalOptions':
						[
						'-std:c++17',
						]
				}
			}

note the placement of {' and ['s

AtiqGauri · 2019-07-06T16:50:20Z

@rvagg still not working

aminya · 2020-11-01T03:29:39Z

This is a full working example for anyone who also has this problem:

{
  "targets": [
    {
      "target_name": "proj",
      "sources": [ "src/proj.cc" ],
      "include_dirs": [
        "<!@(node -p \"require('node-addon-api').include\")"
      ],
      'defines': [ 'NAPI_DISABLE_CPP_EXCEPTIONS' ],
      "cflags": [ "-fno-exceptions" ],
      "cflags_cc": [ "-fno-exceptions", "-std=c++17" ],
      "conditions": [
        ['OS=="mac"', {
            "xcode_settings": {
              'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
              "CLANG_CXX_LIBRARY": "libc++",
              "CLANG_CXX_LANGUAGE_STANDARD":"c++17",
              'MACOSX_DEPLOYMENT_TARGET': '10.14'
            }
        }],
        ['OS=="win"', {
          "msvs_settings": {
            "VCCLCompilerTool": {
              "AdditionalOptions": [ "-std:c++17", ],
            },
          },
        }]
      ]
    }
  ]
}

mceIdo · 2021-01-04T23:27:34Z

The solutions above didn't work for me - the only way I could get it to work was using

"msbuild_settings": {
    "ClCompile": {
        "LanguageStandard": "stdcpp17"
    }
}

It thows off some warnings, but it configures the project as it should and compiles

Akarinnnnn · 2021-01-05T01:48:25Z

The solutions above didn't work for me - the only way I could get it to work was using
"msbuild_settings": {
    "ClCompile": {
        "LanguageStandard": "stdcpp17"
    }
}
It thows off some warnings, but it configures the project as it should and compiles

Yes. ClCompile MSBuild item controls how compiler treats source file

aminya · 2021-01-06T01:37:14Z

The solutions above didn't work for me

That's strange. None of the given solutions sets the standard in the sln file for the analysis. But it works for the build.

Akarinnnnn · 2021-01-06T02:31:55Z

The solutions above didn't work for me

That's strange. None of the given solutions sets the standard in the sln file for the analysis. But it works for the build.

see .vcxproj file?

AtiqGauri · 2021-01-06T02:36:50Z

If anyone need solution irrespective of node-gyp use can use cmake... You can do this using cmake-js node package.
It easily handle these kind of things. Here is a example for you: https://www.github.com/AtiqGauri/Patternscape/tree/master/Patternscape_Native_Addon%2FCMakeLists.txt

aminya · 2021-01-06T02:37:39Z

The solutions above didn't work for me

That's strange. None of the given solutions sets the standard in the sln file for the analysis. But it works for the build.

see .vcxproj file?

Node-gyp should be able to do this automatically, but it does not. CMake easily does it by using.

set(CMAKE_CXX_STANDARD 17)

If anyone need solution irrespective of node-gyp use can use cmake... You can do this using cmake-js node package.
It easily handle these kind of things. Here is a example for you:

Thanks! I need to transfer to cmake-js. Too many problems with node-gyp. It does not solve anything for me as I have to manually maintain compiler flags for all the platforms.

ToadKing · 2021-01-12T15:59:33Z

Ran into this issue myself. Setting it through "msbuild_settings" worked but I think doing it that way messes up the node.exe hooking stuff since the compiled module would not load in electron. It also changes some other flags as well since the module no longer built as a static binary.

@refack's original suggestion worked for me. That said, the "VCCLCompilerTool" option should probably be updated to allow setting "LanguageStandard" directly instead of adding it through an additional command line option.

julianmesa-gitkraken · 2022-10-06T15:08:12Z

         "msvs_settings": {
            "VCCLCompilerTool": {
              "AdditionalOptions": [
                "/std:c++17"
              ]
            }
          },

lirf233 · 2023-11-09T07:14:49Z

Add the following to your binding.gyp:

  'msvs_settings': {
    'VCCLCompilerTool': {
      'AdditionalOptions': [ '-std:c++17', ],
    },
  },

nice, it works!!

DanielCaspers · 2024-09-03T20:49:04Z

For those coming here trying to get C++ 20 working with node addons relying on either Node directly or a derivative (e.g. Electron), don't forget that on Windows you will need to specify /Zc:__cplusplus. It took a while for me to discover this sharp windows specific edge...
https://stackoverflow.com/questions/63057156/language-supported-in-visual-studio-for-c-cplusplus-is-showing-as-c98/63057345#63057345

Psychlist1972 · 2024-09-06T19:04:44Z

In my case, the -std:c++17 didn't work with VS 2022 and MS Build. I had to use the CLCompile version mentioned above.

I was banging my head up against the wall trying to find out how to override the C++20 that node-gyp was putting into the vcxprj but never could locate the source.

This is all because NodeRT uses C++ CX to create the projections, and that is not compatible with C++ 20.

    "msbuild_settings":{
        "ClCompile":{
            "LanguageStandard": "stdcpp17",
            "AdditionalOptions": "/ZW",
            "AdditionalUsingDirectories": [
              "%ProgramFiles(x86)%/Microsoft Visual Studio 14.0/VC/lib/store/references",
              "%ProgramFiles%/Microsoft Visual Studio 14.0/VC/lib/store/references",
              "%ProgramFiles(x86)%/Windows Kits/10/UnionMetadata/10.0.20348.0",
              "$(VCToolsInstallDir)/lib/x86/store/references",
              "../../",
            ]

        }
    }

I still have this in the binding.gyp, but it is overridden by the msbuild settings above

    "msvs_settings": {
      "VCCLCompilerTool": {
        "AdditionalOptions": ["/ZW", "-std:c++17"],
        "DisableSpecificWarnings": [4609],
      }
    },

Psychlist1972 · 2024-09-06T19:06:31Z

For those coming here trying to get C++ 20 working with node addons relying on either Node directly or a derivative (e.g. Electron), don't forget that on Windows you will need to specify /Zc:__cplusplus. It took a while for me to discover this sharp windows specific edge... https://stackoverflow.com/questions/63057156/language-supported-in-visual-studio-for-c-cplusplus-is-showing-as-c98/63057345#63057345

In my case, node-gyp was adding both that and the /std:c++20 to the project file by default, with no obvious way to override.

refack added Windows question labels Feb 7, 2019

davalapar mentioned this issue Mar 1, 2019

Windows build failure on outdated node-gyp (msvs_version=2015) @ Windows 7 x64 luizperes/simdjson_nodejs#1

Closed

rvagg closed this as completed Jun 20, 2019

mceIdo mentioned this issue Jan 4, 2021

node-gyp ignores (c++17) cflag #1543

Closed

richardlau mentioned this issue Sep 3, 2021

build: compile with --gnu++17 nodejs/node#38807

Closed

This was referenced Oct 3, 2021

[Snyk] Security upgrade standard from 14.3.4 to 16.0.4 baby636/node-gyp#2

Open

[Snyk] Security upgrade standard from 14.3.4 to 16.0.4 XirdigH/node-gyp#2

Open

MarshallOfSound mentioned this issue May 12, 2022

chore: bump chromium to 103.0.5046.0 (main) electron/electron#33906

Merged

themastersoda mentioned this issue Oct 7, 2022

Rebuilding native dependencies don't work for Electron 20 and up electron-userland/electron-builder#7175

Closed

maximilize mentioned this issue Oct 20, 2022

Support build for electron v20 WiseLibs/better-sqlite3#870

Merged

This was referenced Mar 17, 2023

[Bug]: Native modules that include nan.h fail to build on electron 20 electron/electron#35193

Closed

Use correct msvs language standard format curlconverter/node-tree-sitter#14

Closed

lemire mentioned this issue Dec 8, 2023

build: enable Clang-cl Windows builds nodejs/node#35433

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Is there any way to use C++17 on MSBuild? #1662

Is there any way to use C++17 on MSBuild? #1662

Akarinnnnn commented Feb 7, 2019

refack commented Feb 7, 2019

Akarinnnnn commented Feb 7, 2019 •

edited by refack

Loading

refack commented Feb 7, 2019

Akarinnnnn commented Feb 8, 2019

rvagg commented Jun 20, 2019

AtiqGauri commented Jul 6, 2019

aminya commented Nov 1, 2020 •

edited

Loading

mceIdo commented Jan 4, 2021

Akarinnnnn commented Jan 5, 2021

aminya commented Jan 6, 2021

Akarinnnnn commented Jan 6, 2021

AtiqGauri commented Jan 6, 2021 •

edited

Loading

aminya commented Jan 6, 2021 •

edited

Loading

ToadKing commented Jan 12, 2021

julianmesa-gitkraken commented Oct 6, 2022

lirf233 commented Nov 9, 2023

DanielCaspers commented Sep 3, 2024

Psychlist1972 commented Sep 6, 2024

Psychlist1972 commented Sep 6, 2024 •

edited

Loading

Is there any way to use C++17 on MSBuild? #1662

Is there any way to use C++17 on MSBuild? #1662

Comments

Akarinnnnn commented Feb 7, 2019

refack commented Feb 7, 2019

Akarinnnnn commented Feb 7, 2019 • edited by refack Loading

refack commented Feb 7, 2019

Akarinnnnn commented Feb 8, 2019

rvagg commented Jun 20, 2019

AtiqGauri commented Jul 6, 2019

aminya commented Nov 1, 2020 • edited Loading

mceIdo commented Jan 4, 2021

Akarinnnnn commented Jan 5, 2021

aminya commented Jan 6, 2021

Akarinnnnn commented Jan 6, 2021

AtiqGauri commented Jan 6, 2021 • edited Loading

aminya commented Jan 6, 2021 • edited Loading

ToadKing commented Jan 12, 2021

julianmesa-gitkraken commented Oct 6, 2022

lirf233 commented Nov 9, 2023

DanielCaspers commented Sep 3, 2024

Psychlist1972 commented Sep 6, 2024

Psychlist1972 commented Sep 6, 2024 • edited Loading

Akarinnnnn commented Feb 7, 2019 •

edited by refack

Loading

aminya commented Nov 1, 2020 •

edited

Loading

AtiqGauri commented Jan 6, 2021 •

edited

Loading

aminya commented Jan 6, 2021 •

edited

Loading

Psychlist1972 commented Sep 6, 2024 •

edited

Loading