-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds fail on macOS with XCode 10 #1454
Labels
gyp: No Xcode or CLT version detected!
See: macOS_Catalina.md
Comments
4 tasks
Did you accept the EULA when installing xcode/xcode CLT? Running edit: oh, I see you opened a PR just now. I'll have a look later today. |
Yup, made sure that wasn't the cause – turned out it's due to the version number matching regex, PRed a fix in #1455 |
Seeing same issues running: Node: v10.4.0
|
bnoordhuis
pushed a commit
that referenced
this issue
Jun 8, 2018
This fixes the regular expression matching in `xcode_emulation` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10 Fixes: #1454 PR-URL: #1455 Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Jun 8, 2018
Trott
pushed a commit
to Trott/npm
that referenced
this issue
Jun 10, 2018
This fixes the regular expression matching in `xcode_emulation` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10 Fixes: nodejs/node-gyp#1454
zkat
pushed a commit
to npm/npm
that referenced
this issue
Jun 28, 2018
This fixes the regular expression matching in `xcode_emulation` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10 Fixes: nodejs/node-gyp#1454 PR-URL: #20948 Credit: @Trott Reviewed-By: @zkat
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(but happens with anything with native bindings)
Verbose output (from local npm install):
Output of /usr/sbin/pkgutil --pkg-info "com.apple.pkg.CLTools_Executables":
The text was updated successfully, but these errors were encountered: