Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-metadata: strange Author info for complicated commits #180

Closed
vsemozhetbyt opened this issue Feb 14, 2018 · 1 comment
Closed

get-metadata: strange Author info for complicated commits #180

vsemozhetbyt opened this issue Feb 14, 2018 · 1 comment
Labels
bug pr-summary

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 14, 2018 •
edited
Loading

PR: nodejs/node#18721

It has a commit with complicated authorship.

Command: winpty get-metadata.cmd 18721

Output: 
√  Done loading data for nodejs/node/pull/18721
----------------------------------- PR info ------------------------------------
Title      doc: update crypo Certficate class. (#18721)
Author     null <> (@antoine-amara)
Branch     antoine-amara:add-info-and-new-link-crypto-doc-#18662 -> nodejs:master
Labels     crypto, doc, ready
Commits    1
 - doc: update crypo Certficate class.
Committers 1
 - Antoine AMARA <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/18721
Fixes: https://github.com/nodejs/node/issues/18662
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
--------------------------------------------------------------------------------
√  Requested Changes: 0
√  Approvals: 2
‼  Commits were pushed since the last review:
‼  - doc: update crypo Certficate class.
i  Last Full CI on 2018-02-14T20:52:05Z: https://ci.nodejs.org/job/node-test-pull-request-lite/171/

Compare these lines:

Author     null <> (@antoine-amara)
...
Committers 1
 - Antoine AMARA <[email protected]>
@priyank-p priyank-p added bug pr-checker Issues related to pr checker labels Feb 14, 2018
@priyank-p
Copy link
Contributor

It looks like the user had correct credentials in git config before but then they somehow changed them causing this to happen. (This might not necessarily be a bug but an enhancement)

@priyank-p priyank-p added pr-summary and removed pr-checker Issues related to pr checker labels Feb 14, 2018
priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Feb 16, 2018
@priyank-p
pr_summary: warn if the PR Author does have valid config setup
5d1bedb 
This displays a warning if PR Author does not have valid config
setup using `git config`. Before it use to just display as:

  `Author null <> (@github-user-name)`

fixes: nodejs#180
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
pr_summary: warn if we can't fetch author's name and email
a9181dd 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
@renawolford6
pr_summary: warn if we can't fetch author's name and email
ce3bda0 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
@logictitans
pr_summary: warn if we can't fetch author's name and email
d35cc2f 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
@gerkai
pr_summary: warn if we can't fetch author's name and email
6e633df 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
@patrickm68
pr_summary: warn if we can't fetch author's name and email
294f53f 
This displays a warning if we cannot fetch user's name and email from github
api, instead of displaying blank and null output in the author field (cli table).

Refs: nodejs/node#18721
Fixes: nodejs/node-core-utils#180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pr-summary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsemozhetbyt @priyank-p