still does not detect some non-author committers

[joyeecheung]

See nodejs/node#17705

[joyeecheung]

It is kind of weird, the committer and the author actually use the same email, and authoredByCommitter is true here, still GitHub UI does not recognize that...

[priyank-p]

Ah, it might be because the remove the email in the settings.

[priyank-p]

@joyeecheung the reason i think it failes is because of this here

node-core-utils/lib/pr_checker.js

Lines 282 to 286 in e76076d

	// They have turned on the private email feature, can't really check
	// anything, GitHub should know how to link that, see nodejs/node#15489
	if (!pr.author.email) {
	return false;
	}

I don't think email field exists on author. Can you tell me exactly what the purpose was here?

(I do think they have a GitHub email provied by github for this purposes of making email private)

[joyeecheung]

@cPhost That is assigned here

node-core-utils/lib/pr_data.js

Lines 84 to 86 in e76076d

	const userData = await request.gql(USER_QUERY, { login: pr.author.login });
	const user = userData.user;
	Object.assign(this.pr.author, user);

[priyank-p]

That seems correct. And also you can do this to save you some from doing more work.

author {
  ... on User {
     email,
     name
  }
}