This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Fix v8 build break #355
Merged
Fix v8 build break #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfarnung
reviewed
Aug 2, 2017
| v8: /^ReferenceError: foo is not defined$/, | ||
| chakracore: /ReferenceError: Use before declaration/ | ||
| })); | ||
| const script = new Script('foo.bar = 5;'); |
There was a problem hiding this comment.
I'm assuming this was just a bad merge?
kfarnung
approved these changes
Aug 2, 2017
MSLaguana
approved these changes
Aug 3, 2017
Fixes: nodejs#354 PR-URL: nodejs#355 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
Fixes: nodejs#354 PR-URL: nodejs#355 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kunalspathak
force-pushed
the
fixv8break
branch
from
d17a3dc
to
270aaa1
Compare
kfarnung
pushed a commit
that referenced
this pull request
Aug 12, 2017
Fixes: #354 PR-URL: #355 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
pushed a commit
that referenced
this pull request
Aug 12, 2017
Fixes: #354 PR-URL: #355 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
pushed a commit
that referenced
this pull request
Aug 14, 2017
Fixes: #354 PR-URL: #355 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
pushed a commit
that referenced
this pull request
Aug 14, 2017
Fixes: #354 PR-URL: #355 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed v8 build break. Also ran through unit test and fixed 2 test cases. There are still 2 unit test failures in inspector that are failing for node-v8. @kfarnung might have idea.
Fixes: #354
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src,test