Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

build: fix ARM build #265

Merged
merged 2 commits into from
May 28, 2017
Merged

build: fix ARM build #265

merged 2 commits into from
May 28, 2017

Commits on May 28, 2017

  1. build: fix ARM build 

    Several fixes needed:
1. Don't pass in the platform to ChakraCore-
   it'll figure out the right SDK version
2. Disable intl on ARM if cross-compiling
3. Set the default SDK version if compiling ARM to
   be v10.0 since Node doesn't seem to compile for
   Windows on ARM with the older SDKs.

PR-URL: nodejs#265
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
    @kfarnung
    kfarnung committed May 28, 2017
    Configuration menu
    Copy the full SHA
    262f7e0 View commit details
    Browse the repository at this point in the history

  2. test: marking new flaky test 

    PR-URL: nodejs#265
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
    @kfarnung
    kfarnung committed May 28, 2017
    Configuration menu
    Copy the full SHA
    e35fd86 View commit details
    Browse the repository at this point in the history