This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: clean up legacy debugger code #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalspathak
approved these changes
May 19, 2017
deps/chakrashim/src/v8context.cc
Outdated
| bool inspectorEnabled = jsrt::Inspector::IsInspectorEnabled(); | ||
|
|
||
| if ((debugEnabled || inspectorEnabled) && | ||
| if (jsrt::Inspector::IsInspectorEnabled() && | ||
| isoShim->debugContext == nullptr) { | ||
| // If JavaScript debugging APIs need to be exposed then make sure | ||
| // debugContext is available and chakra_debug.js or chakra_inspector.js |
There was a problem hiding this comment.
chakra_debug [](start = 37, length = 12)
nit: remove
|
|
Since debugger support was removed upstream, this change removes the corresponding chakrashim code. PR-URL: nodejs#250 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Sandeep Agarwal <[email protected]>
PR-URL: nodejs#250 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Sandeep Agarwal <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
May 23, 2017
Since debugger support was removed upstream, this change removes the corresponding chakrashim code. PR-URL: nodejs#250 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Sandeep Agarwal <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
May 23, 2017
PR-URL: nodejs#250 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Sandeep Agarwal <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
May 23, 2017
Since debugger support was removed upstream, this change removes the corresponding chakrashim code. PR-URL: nodejs#250 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Sandeep Agarwal <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
May 23, 2017
PR-URL: nodejs#250 Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Sandeep Agarwal <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since debugger support was removed upstream, this change removes the
corresponding chakrashim code.
Resolves #225
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim