This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
build: remove a pattern that only matched the MSI #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzoz
approved these changes
Nov 17, 2016
joaocgreis
added a commit
that referenced
this pull request
Nov 17, 2016
Ref: #139 PR-URL: #141 Reviewed-By: Bartosz Sosnowski <[email protected]>
joaocgreis
added a commit
that referenced
this pull request
Nov 17, 2016
Ref: #139 PR-URL: #141 Reviewed-By: Bartosz Sosnowski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Build
Description of change
Removes a glob pattern that only matched the MSI, no longer needed after #139 .
I would like to fast-track this, unless there are objections.
cc @nodejs/node-chakracore